ctsit / rcc.billing

Automated, data-driven service billing implemented on REDCap Custodian
https://ctsit.github.io/rcc.billing/
Apache License 2.0
0 stars 3 forks source link

Add etl vignettes #244

Closed pbchase closed 3 months ago

pbchase commented 3 months ago

These new vignettes need SIPOCs. Could you add them to the best of your ability?

saipavan10-git commented 3 months ago

@pbchase I added SIPOCs for these ETL Vignettes cleanup_project_ownership_table cleanup_bad_project_pi_email_addresses update_invoice_line_items_with_invoicing_details

pbchase commented 3 months ago

I'm happy if you are happy.

pbchase commented 3 months ago

I'm going to merge this so I can build on it

saipavan10-git commented 3 months ago

Should we align update_invoice_line_items_with_invoicing_details SIPOC Top-down as well?

pbchase commented 3 months ago

I couldn't control the appearance when it was TD so I switched it back to LR. I'd rather go TD if you can find a way to control the appearance. I just felt like I needed to move on and optimize it later

saipavan10-git commented 3 months ago

Sounds good 👍