search

ctsit / rcc.billing

Automated, data-driven service billing implemented on REDCap Custodian
https://ctsit.github.io/rcc.billing/
Apache License 2.0
0 stars 3 forks source link

Fix cleanup_bad_email_addresses.R #245

Closed saipavan10-git closed 3 months ago

saipavan10-git commented 3 months ago

Remove usage of get_uf_person_data_by_gatorlink() as data.vivo.ufl.edu doesn’t exist anymore. Addresses #243

pbchase commented 3 months ago

I reviewing this PR, I figured out your use of Remotes in DESCRIPTION causes a few warnings in the build checker:

 checking dependencies in R code ... WARNING
  '::' or ':::' imports not declared from:
    ‘RMariaDB’ ‘rcc.ctsit’ ‘redcapcustodian’

❯ checking Rd cross-references ... WARNING
  Missing link or links in Rd file 'get_orphaned_projects.Rd':
    ‘connect_to_redcap_db’

  Missing link or links in Rd file 'get_service_request_line_items.Rd':
    ‘connect_to_redcap_db’

  Missing link or links in Rd file 'update_billable_by_ownership.Rd':
    ‘dataset_diff’

  Missing link or links in Rd file 'update_billable_if_owned_by_ctsit.Rd':
    ‘dataset_diff’

  See section 'Cross-references' in the 'Writing R Extensions' manual.

I also realized the is-faculty() function is fatally broken due to the missing data source. That, in turn, is breaking a production ETL, cleanup_project_ownership_table.R I am removing the rcc.ctsit dependencies by removing features and the code behind them.

pbchase commented 3 months ago

The build warnings are now down to these:

❯ checking dependencies in R code ... WARNING
  '::' or ':::' import not declared from: ‘redcapcustodian’

❯ checking Rd cross-references ... WARNING
  Missing link or links in Rd file 'get_orphaned_projects.Rd':
    ‘connect_to_redcap_db’

  Missing link or links in Rd file 'get_service_request_line_items.Rd':
    ‘connect_to_redcap_db’

  Missing link or links in Rd file 'update_billable_by_ownership.Rd':
    ‘dataset_diff’

  Missing link or links in Rd file 'update_billable_if_owned_by_ctsit.Rd':
    ‘dataset_diff’

  See section 'Cross-references' in the 'Writing R Extensions' manual.

I have read they are fixable with drat. Not sure if that is right or not. I am OK with the build warnings for now.

pbchase commented 3 months ago

Please check my work. Your work was fine, I just wanted rcc.ctsit gone.

saipavan10-git commented 3 months ago

The changes look good. Should I update the workflow yaml's to reflect the dependency change in this PR?

pbchase commented 3 months ago

The changes look good. Should I update the workflow yaml's to reflect the dependency change in this PR?

Yes, please. I think you understand that better than I do.

saipavan10-git commented 3 months ago

I updated the workflows. Run-tests workflow is running fine. pkgdown workflow dry-run was successful when ran locally.