ctsit / rcc.billing

Automated, data-driven service billing implemented on REDCap Custodian
https://ctsit.github.io/rcc.billing/
Apache License 2.0
0 stars 3 forks source link

`request_correction_of_bad_ownership_data.R` is missing project designers #248

Open pbchase opened 3 months ago

pbchase commented 3 months ago

request_correction_of_bad_ownership_data.R does not use role data to locate project designers who get permission via that path.

Consider refactoring the code to use get_user_rights_and_info(). It hides the complexity of resolving permissions. It returns all the active permissions for every project. Substitute it for rcur at https://github.com/ctsit/rcc.billing/blob/9f201b1b546c1b4dea45f1e461e670090a80182d/report/request_correction_of_bad_ownership_data.R#L61, remove line 64, and remove unused objects at lines 25 and 26. That might be enough to fix the issue.