search

ctsit / redcapcustodian

Simplified, automated data management on REDCap systems
Other
12 stars 6 forks source link

Add objects_to_include param to unnest_job_summary_data_json_object() #115

Closed pbchase closed 7 months ago

pbchase commented 1 year ago

Addresses Issue #112 and #113.

pbchase commented 7 months ago

@ChemiKyle, this PR is getting lonely. It is very sad.

So is @emilyolsen246 , 'cause she needs it. :-(

ChemiKyle commented 7 months ago

I was holding off on merging this because it has the strange issue in vignettes of complaining about dependencies despite them being called with library.

❯ checking for unstated dependencies in vignettes ... NOTE
  '::' or ':::' imports not declared from:
    ‘dotenv’ ‘here’
  'library' or 'require' calls not declared from:
    ‘kableExtra’ ‘tidyverse’

I'll just merge since it's blocking now and I'm not pedantic enough to consider a warning in a vignette that important.

pbchase commented 7 months ago

I was holding off on merging this because it has the strange issue in vignettes of complaining about dependencies despite them being called with library.

@ChemiKyle, you were right to be concerned. The vignette would not build in Github CI. I am already working on https://github.com/ctsit/redcapcustodian/pull/142.