Closed bonesoul closed 10 years ago
@ctstone Fixed hashtests & keystests. Now just need to to fix SortedSetTests and we'll be all good.
Very nice!
Note that I've also fixed the original bug regarding the missing async exception. Following should now raise an AggregateException:
client.DelAsync("test"); client.HSetAsync("test", "field1", "str"); var result = client.HIncrByFloatAsync("test", "field1", 1.5).Result; // now fails with ERR hash value is not a valid float
On Tue, Aug 5, 2014 at 9:53 AM, Hüseyin Uslu notifications@github.com wrote:
@ctstone https://github.com/ctstone Fixed hashtests & keystests. Now just need to to fix SortedSetTests and we'll be all good.
— Reply to this email directly or view it on GitHub https://github.com/ctstone/csredis/pull/16#issuecomment-51199927.
@ctstone I'm now done with invariant-culture stuff and tests all run perfectly fine within my non en-US system (Turkish).
You are good to go to merge in if you liked the fixes - and please make sure to run tests in your en-US system to make sure everything works fine :)
Nice appveyor was able to build and run the tests.
hey @ctstone were you able to check the PR, any comments or changes you'd like to see?
Everything looks good.. thanks!
But I'll need to roll back this release to non-production status due to the async issues. Keep an eye out for updates soon.
On Tue, Aug 5, 2014 at 5:53 PM, Hüseyin Uslu notifications@github.com wrote:
hey @ctstone https://github.com/ctstone were you able to check the PR, any comments or changes you'd like to see?
— Reply to this email directly or view it on GitHub https://github.com/ctstone/csredis/pull/16#issuecomment-51265789.
async and even pipeline issues here; https://github.com/ctstone/csredis/issues/18
Floating point fix done, need to fix a few others too.