AACT-561: Remove connection information from application.rb and use database.yml instead

ctti-clinicaltrials / aact

Improving Public Access to Aggregate Content of ClinicalTrials.gov

http://aact.ctti-clinicaltrials.org

MIT License

124 stars 33 forks source link

AACT-561: Remove connection information from application.rb and use database.yml instead #1089

Closed Javier-Jimenez-18 closed 9 months ago

Javier-Jimenez-18 commented 10 months ago

Removed instances of environment variables for these database urls: AACT_BACK_DATABASE_URL, AACT_ADMIN_DATABASE_URL, and AACT_PUBLIC_DATABASE_URL.
Replaced them with references to the database.yml
Tested that everything still works:

Loading Studies

Restoring the Database

Javier-Jimenez-18 commented 9 months ago

Removed database connection variables in application.rb file for AACT back, admin, public, and hostname for test and non-test rails environments.
Removed unused database connection variables from .env.example, README.md, and spec file.
Corrected wording, spelling, and layout in README.md file.
Tested that everything still works:

Loading Studies

Restoring the Database

micronix commented 9 months ago

@Javier-Jimenez-18 some of the tests were failing, you didn't notice because right now not all of our tests are passing on aact-core, but take a look at how I fixed it in the last PR. I think this looks good now.