Kostik/central contacts data mapper/aact 616

ctti-clinicaltrials / aact

Improving Public Access to Aggregate Content of ClinicalTrials.gov

http://aact.ctti-clinicaltrials.org

MIT License

123 stars 33 forks source link

Kostik/central contacts data mapper/aact 616 #1115

Closed kostik700015 closed 6 months ago

kostik700015 commented 7 months ago

This PR adds the central_contacts_data method in ProcessorV2, that parses and processes centralContacts using apiV2.

kostik700015 commented 6 months ago

Looks good. I have a question for Ramiro about what should we call our spec files? For the method study_data, I originally called it processor_v2_spec.rb, like you did, but I then renamed it to study_data_spec.rb. Let's find out so that we can be consistent.

Thank you for reviewing Javier.

Javier-Jimenez-18 commented 6 months ago

Hey Konstantin, I was right the first time about the spec file name processor_v2_spec.rb and you did it correctly. I renamed it back.