search

ctu-mrs / simulation

The OLD Gazebo Simulation repository.
https://github.com/ctu-mrs/mrs_uav_system
BSD 3-Clause "New" or "Revised" License
48 stars 17 forks source link

Making the upgrade more specific #6

Closed ViktorWalter closed 4 years ago

ViktorWalter commented 4 years ago

Calling full system upgrade without even asking the user is a horrible idea. Several rather difficult to set up things just got broken for me, since I specifically use selected versions of some software and I have to manually override some dependencies. I doubt that I am the only one in the wild who does this and this is a public repo. I suggest this change - specifically upgrade what we need. Alternatively, remove the -y, so that the user is at least informed.

klaxalk commented 4 years ago

I agree that this was not "polite". However, I would advise making your system work with the up-to-date packages. So when the time comes to, e.g., reinstall you Ubuntu, you will not be in huge trouble.

petrlmat commented 4 years ago

If you need a specific version of a package and still want to be able to upgrade your system I recommend holding the package using apt-mark hold <package>.

ViktorWalter commented 4 years ago

Thanks. In ideal world, having everything up-to-date would be the best possible setup. In reality, however, this is not always possible. Case in point - Cuda and Nvidia graphics drivers are always paired version-wise. However, some versions of the NVidia drivers break my X11 on my laptop, and these are typically the new (untested) ones that are paired with a Cuda version that I need. @petrlmat can I do the hold system-wide? That is - if I do it once, will it persist through all subsequent upgrade commands?

klaxalk commented 4 years ago

Oh, apt-mark hold, I did not know that. That is great! We should probably "hold" our Mavros since its new version will immediately cause a compilation error of the uav_core.