search

ctubio / Krypto-trading-bot

Self-hosted crypto trading bot (automated high frequency market making) written in C++
https://127.0.0.1:3000
Other
3.37k stars 823 forks source link

Improvement: choosing number of decimals? #580

Closed Camille92 closed 6 years ago

Camille92 commented 6 years ago

Hi Carles and everyone,

Now that everything is truncated with 2 decimals, I have many markets where I can't really look at the data to know what the bot has done because of price = 0.00 ...

Also, I understand that for people trading in BTC/USD or ETH/USD having many decimals is annoying. capture d ecran 2018-01-17 a 10 22 43

So here are my 2 propositions to fix that problem and make everyone happy:

1) Converting all prices to a "123.45" scheme. So artificially multiplying or dividing price in the web UI so they are easily comparable. And obviously, add the info on how much prices are multiplicated or divided using the scientific writing. Ie: 10^-2: Prices are divided by 100 10^5 Prices are multiplicated by 100000

2) The second idea, keeping it "as if" but adding an option to chose the number of decimals somewhere next to K memory and profit. Where the number you put is the number of decimals after 0. So if you put 3 prices are going to be displayed with a price precision of 1/1000 or 0.001. If you put 6 prices are going to be displayed with a price precision of 1/1000000 or 0.000001

Tell me what you think about that!

And good luck in this time of complicated trading :)

ctubio commented 6 years ago

thanks for the suggestions''' will decide for one soOn''

ctubio commented 6 years ago

what about using the same amount of decimals as in the price of the market levels?

Camille92 commented 6 years ago

Sounds good and easy to me! Actually it sound more logical than what I proposed haha !

veryfastreply

Le 18 janv. 2018 02:08, "Carles Tubio" notifications@github.com a écrit :

what about using the same amount of decimals as in the price of the market levels?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ctubio/Krypto-trading-bot/issues/580#issuecomment-358503562, or mute the thread https://github.com/notifications/unsubscribe-auth/AGizFvHa6fjUOtu-jCe0MvCKhBPD5OLhks5tLpl7gaJpZM4RhCoL .

ctubio commented 6 years ago

sorry in what exchange/pairs you saw 0.00 prices? thanks for the info''

Camille92 commented 6 years ago

So in Bitfinex,

USD pairs: FUN and TNB with only 1 digit (0.01) BTC pairs: 0.00 for ETC, XRP, IOTA, EOS, SAN, OMG, ETP, QTM, AVT, EDO, DAT, QSH, YYW, GNT, SNT, BAT, MNA, FUN, ZRX, TNB, SPK.

Camille92 commented 6 years ago

Hey Carles,

Actually I was wrong, because the latest coins I added have all the decimals I need. Maybe it's due to an issue in older database ?

ctubio commented 6 years ago

maybe cos im looking at the codes of the trades table and is not fixed to 2 decimals, is variable based on minTick like the market levels

feel free to close the issue or let me know in case you still think some decimal is wrong; im a bit confused now cos to me seems correct; it is correct for you too now?

ctubio commented 6 years ago

in latest commit i had cleanup a bit the ui functions; hope you dont miss any decimal after the last commit; please let me know if you feel the val values in the trades history are missing decimals otherwise i will close this soOn'' :dancer:

many thanks for you time''

Camille92 commented 6 years ago

Thank you for working on it!

I'll update soon and tell you :)