ctubio / Krypto-trading-bot

Self-hosted crypto trading bot (automated high frequency market making) written in C++
https://127.0.0.1:3000
Other
3.29k stars 815 forks source link

support for Binance #606

Closed frndxyz closed 3 years ago

frndxyz commented 6 years ago

can you please add binance support in bot?

thanks..

donaldforest commented 6 years ago

Why Binance? I mean not so low fees, no Web Socket API + API restrictions by amount of reads\operation per second.

https://github.com/ctubio/Krypto-trading-bot/issues?utf8=%E2%9C%93&q=binance

donaldforest commented 6 years ago

In any case we need Binance too.

donaldforest commented 6 years ago

I with you! ;)

jwvanderbeck commented 6 years ago

Not so low fees? Binance has some of the lowest fees I've seen.

Anyway I'm just poking my nose into the world of trading bots, but since I'm a programmer I might take a look at doing this after some more research to see if this is the bot I want to learn. Assuming the project isn't against adding Binance support.

donaldforest commented 6 years ago

@jwvanderbeck Will be cool, but adding new exchange to K bot its not opensource part of project. :(

tuxitor commented 6 years ago

@ctubio, I will give you a few reasons to why it is worthwhile to implement a Binance interface.

On a typical day Binance trades around 1.2 billion USD (1,200,000.000) within 24 hours. How much Binance keep in their own pockets for this is impossible to tell exactly, but the trading fee is in the range 0.05% to 0.1% which gives Binance the average profit on a beautiful day something between 600.000 and 1.2 million USD.

The idea is how you can sqeeze a little bit out of Binance's insanely hight profits. The referral option on Binance can be very profitable. You can benefit from their referral program by having referral "friends" and give them the license for free. With this license option you can have a lot more bot users by hanging this carrot in front of them. Some of the bot users already have an account, but it is deadly easy to create a another new account by only have an email address, refer to you as "friend" and let your bot generate steady income. You will then get 20% of the referral friends fee directly into your account. The more trading the bot does, the more profit from the referral friends. This will generate referral comission as long as the bot runs. It's a win/win situation. From this screenshot you can see how much the top performers get from comission. You can also see what I have got up to now in short time with only 7 referral friends not using bots.

image

serzhiio commented 6 years ago

Man, you made great Binance advertisement. Please consider that this bot is for market making and Binance offer nothing to this type of traders. There is no difference between makers and takers. Binance has slow API that refreshes only one time in a second. There are a lot more cons about binance, but its good exchange for mid to long term strategies.

сб, 7 июля 2018 г., 11:10 tuxitor notifications@github.com:

@ctubio https://github.com/ctubio, I will give you a few reasons to why it is worthwhile to implement a Binance interface.

  • According yo Coinmarketcap, last 24 hours Binance has a trading volume of nearly 1.2 billion USD, which is 4 times that of Bitfinex. https://coinmarketcap.com/exchanges/volume/24-hour/
  • They have low fees ranging from 0.05% to 0.1%
  • Draw users that already are trading on Binance
  • An idea about how you can benefit even more from Binance by introducing a new license alternative.

On a typical day Binance trades around 1.2 billion USD (1,200,000.000) within 24 hours. How much Binance keep in their own pockets for this is impossible to tell exactly, but the trading fee is in the range 0.05% to 0.1% which gives Binance the average profit on a beautiful day something between 600.000 and 1.2 million USD.

The idea is how you can sqeeze a little bit out of Binance's insanely hight profits. The referral option on Binance can be very profitable. You can benefit from their referral program by having referral "friends" and give them the license for free. With this license option you can have a lot more bot users by hanging this carrot in front of them. Some of the bot users already have an account, but it is deadly easy to create a another new account by only have an email address, refer to you as "friend" and let your bot generate steady income. You will then get 20% of the referral friends fee directly into your account. The more trading the bot does, the more profit from the referral friends. This will generate referral comission as long as the bot runs. It's a win/win situation. From this screenshot you can see how much the top performers get from comission. You can also see what I have got up to now in short time with only 7 referral friends not using bots.

[image: image] https://user-images.githubusercontent.com/26491085/42408383-2afb06fa-81cc-11e8-9d96-1a75d63f6aba.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ctubio/Krypto-trading-bot/issues/606#issuecomment-403197806, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9ytycqHgS_3WAZUWCPaKNAUm2Dm-Fnks5uEGzugaJpZM4RuI_d .

KaseMaster commented 6 years ago

Pues yo me sumo a la solicitud del amigo @ctubio Binance es uno de los intercambios donde suelo operar yo y toda la gente que conozco en trading. Una lástima.

Por otro lado, el bot es un excelente trabajo!! Y una gran ayuda al nacimiento de la nueva economía y a la LIBERTAD. Un saludo a tod@s!

ctubio commented 5 years ago

binance have many limitations, for example 100000 orders per day.

at 500 orders per minute, if you open the bot when you go to bed, you will be banned before you wake up

at 100 orders per minute, if you open the bot when you go to bed, if you wakeup and go to office without stopping the bot, you will be banned before you come back home

ctubio commented 5 years ago

see https://api.binance.com//api/v1/exchangeInfo

and https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md#limits:

violating rate limits = IP ban 3 days.

i just need to say that usualy exchanges ban users 30 seconds.. (while having no stupid limits)

ctubio commented 5 years ago

only i will consider binance if they move the order place/cancel request to the WS API (currently they only have the order status response if im not wrong; like FCoin,,); i really dont wanna add more slow REST API exchanges like Poloniex/Kraken/Korbit/FCoin.. (too many accmulated deceptions xD)

(:bulb: feel free to spam their support inbox with this requirement; for binance or any of the above slow exchanges)

ctubio commented 5 years ago

ws docs at https://github.com/binance-exchange/binance-official-api-docs/blob/master/web-socket-streams.md but sadly is just for market data, not for orders

ctubio commented 3 years ago

:koala: done since https://github.com/ctubio/Krypto-trading-bot/commit/19361ee7436bfaa35252be78e5689d346d7ef103