ctubio / tribeca

Self-hosted crypto trading bot (automated high frequency market making) in node.js, angular, typescript and c++
https://127.0.0.1:3000
Other
95 stars 26 forks source link

(BUG) Coinbase LTC/BTC & ETH/BTC markets don't work #134

Closed Camille92 closed 7 years ago

Camille92 commented 7 years ago

Hello again Carles,

First of all, thanks for implementing the FIX API a Coinbase ! Just to know, do you have any stats about it ? It is actually faster ? I've never used FIX before so I'm not sure what's the performance difference between FIX and Websocket ^^".

Now the main issue, I don't know why but no order is sent on the LTC/BTC and ETH/BTC market with the new version.

Everything looks fine, I get my balance, it's connected from the exchange, the market is updated etc... but no order is sent!

Any idea why?

PS: It might be interesting to put that somewhere in the notes but for FIX to work, I had to create an API key for each market!

ctubio commented 7 years ago

thanks for the report of the multiple api keys! is true it said that in the docs, i will add to our docs too

about your bug, im not able to reproduce it, can you try to simply restart the app? because https://github.com/ctubio/tribeca/issues/131

Camille92 commented 7 years ago

I did it and nothing changes did you try to run all the markets together?

Camille92 commented 7 years ago

FOUND IT! The error seems to come with the % option.

When it's desactivated it works but it is blocked when activated :/

ctubio commented 7 years ago

answering to your speed question: FIX is as fast as WebSocket, but Coinbase WebSocket is only for market data; to place orders we can use only HTTPS calls or FIX (so we use FIX).

ctubio commented 7 years ago

about your bug, im not able to reproduce it yet, i switched also % but found no impact; i would say that all my Coinbase bots are working OK

Camille92 commented 7 years ago

Thank you for the update on FIX. :)

For the bug, when you go from % "unswitched" to "switched" the last orders still appear on the UI, but if you check on gdax website nothing is there.

Can you please check if it is the same for you?

ctubio commented 7 years ago

is true that the last order remains in the UI after all have been canceled (so in the market theres not really any open order).

but this have nothing to do with the ability to continue trading, as soon as is decided to place a new order, it happens OK.

the confusion may be that for whatever other reason the app is not deciding to place orders, maybe some quoting parameters are blocking orders for the side that you expect to have orders?

ctubio commented 7 years ago

tribeca shows orders in the UI when order are canceled IF quoting state for that side is off (still looking for a fix, but is just a cosmetic)

Camille92 commented 7 years ago

Yes, that's not very important.

I don't know what that can be, I used the same settings that worked as expected but since I updated yesterday afternoon it didn't work. I'll try to find where that comes from

ctubio commented 7 years ago

IF in the logs you see FIX Initiator Started and Logon true, mean that the connection is OK, so the problem may be some settings in the quoting parameters

im sorry it happened to me too much times this, so i believe is your issue too; but i keep monitoring my Coinbase bots in case i notice something similar not related to the ethernal human errors

ctubio commented 7 years ago

hope you don't mind if i close the issue meanwhile im not able to reproduce it, still is open in my heart and brain :dancer: (lets debug!)

ctubio commented 7 years ago

another thing we can do is if you paste/screenshot me somehow your settings i can try them and see if happens the same, not sure if we have other options

Camille92 commented 7 years ago

Yes I'll do that! I think the fix connection works well because it trades when I change the settings. I'll do that when I go home :)

Le 13 juin 2017 19:16, "Carles Tubio" notifications@github.com a écrit :

another thing we can do is if you paste/screenshot me somehow your settings i can try them and see if happens the same, not sure other options

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ctubio/tribeca/issues/134#issuecomment-308186492, or mute the thread https://github.com/notifications/unsubscribe-auth/AGizFivm-Zl94MrWw3_X4yjIeQHX3FyFks5sDsPjgaJpZM4N4Xfa .

Camille92 commented 7 years ago

I post that here!

See here, the % is off and the bot is trading:

capture d ecran 2017-06-14 a 14 54 52

When I turn it on -> it stops! capture d ecran 2017-06-14 a 14 57 15