ctuning / ck-tensorflow

Collective Knowledge components for TensorFlow (code, data sets, models, packages, workflows):
http://cKnowledge.org
BSD 3-Clause "New" or "Revised" License
93 stars 26 forks source link

Rename ck-tensorflow:classification-* programs #68

Closed Chunosov closed 6 years ago

Chunosov commented 6 years ago

classification-tensorflow -> benchmark-tensorflow-python classification-tensorflow-cpp -> benchmark-tensorflow-cpp classification-tflite-cpp -> benchmark-tflite-cpp

Because we already have the set of tensorflow-classification* programs with similar names but different intention (usage of single image only and for mobile demo).

But it should be done after merging of https://github.com/ctuning/ck-tensorflow/pull/66 to avoid conflicts.

gfursin commented 6 years ago

We need to check it with @psyhtest - we thought to keep program names as they are now (unless we update all docs), and maybe create a separate repo for image classification ... Not sure yet what is the best ... The problem is that name "benchmark" is over-abused and doesn't tell much about what the program does ...

Chunosov commented 6 years ago

OK, agree. May be it was too hasty suggestion. "benchmark" is quite common word, but these programs do just classification.

psyhtest commented 6 years ago

We have agreed to adopt the following convention: <task>-<model>-<framework> for a model-specific program and <task>-<framework> for a model-agnostic one (similar to TDB), where <task> is "image classification".

So how about:

Similarly, we would use e.g. image-classification-mobilenets-armcl-opencl

Chunosov commented 6 years ago

is tflite cpp-only?

It seems to be. There is some lite.py module in tflite dir, but I'm not sure if it is TFLite API. It says "TensorFlow Lite tooling helper functionality" and refers primary to some toco that should mean 'TensorFlow optimized converter'

Chunosov commented 6 years ago

Here is the renaming: https://github.com/ctuning/ck-tensorflow/pull/69

psyhtest commented 6 years ago

We should update at least the following references:

Chunosov commented 6 years ago

There are more references corrected here https://github.com/ctuning/ck-tensorflow/pull/71

gfursin commented 6 years ago

If this is done, we should close it ...