search

cu-ecen-aeld / assignment-autotest

Auto test code for assignments, using the Unity automated test framework
MIT License
3 stars 20 forks source link

assignment8 instructions confusion #27

Closed isch4196 closed 1 month ago

isch4196 commented 1 year ago

The instructions in assignment-autotest/test/assignment8 aren't quite clear. What I assume to be the correct way to test is to reload the driver each time you run a test. For example, after running drivertest.sh, you would reload the driver and then run sockettest.sh. If the driver isn't reloaded, you end up reading the wrong strings, and therefore fail the test.

I can create a PR to edit the instructions if this is deemed to be an issue.

straend commented 1 year ago

That is also what I found out, but then we have problems with the test also. It tries to unload the module while our socket-server is running.

isch4196 commented 1 year ago

Hi @straend , were you able to figure it out? I think I had the same problem when I was implementing this before, although my memory is a bit hazy. The "troubleshooting" section at the bottom of the assignment 8 instructions should address it: "ensure you are not opening the file descriptor for your driver endpoint from aesdsocket until it is accessed".

straend commented 1 year ago

Hi @isch4196, yeah I missed the troubleshooting steps listed there. Thank You for pointing out that.

dwalkes commented 1 month ago

Thanks for the feedback, I've updated the assignment 8 instructions to state this in step 5 as well to hopefully make this requirement more clear.