search

cu-mkp / editioncrafter

Software for the development of EditionCrafter, digital critical edition publication tool
https://editioncrafter.org/
MIT License
9 stars 3 forks source link

Thumbnails not maintaining aspect ratio #148

Open NickLaiacona opened 5 days ago

NickLaiacona commented 5 days ago

The page images do not retain their aspect ratio when displayed as thumbnails. Example:

https://editioncrafter.org/projects/odt/#/ec/passio_verbigenae_f002/g/passio_verbigenae_f002/f/-1/g

camdendotlol commented 5 days ago

So currently the thumbnail feature figures out which dimensions to require for the thumbnail based on the aspect ratio of the width and height attributes provided by the IIIF manifest. For example, an image that's 2000x1000 will have a thumbnail with dimensions of 130x75.

The manifest in that example (https://cu-mkp.github.io/odt-editioncrafter-data/texts/caryatidum/iiif/manifest.json) says that each item is 800x1000, which is incorrect. The thumbnail display matches the 4:5 aspect ratio.

Did those numbers originally come from a third-party manifest? I'm not sure if this indicates a bug in the CLI app or if it's just bad data from a third-party source.