cu-mkp / editioncrafter

Software for the development of EditionCrafter, digital critical edition publication tool
https://cu-mkp.github.io/editioncrafter/
MIT License
8 stars 3 forks source link

Redesign zone UI #63

Closed camdendotlol closed 1 year ago

camdendotlol commented 1 year ago

Summary

The one divergence from the mockup is that I had to keep the existing horizontal margins in the transcription view. The structure of the HTML elements in the transcription view makes it impossible to display the blue background all the way to the edges while keeping the text margins.

Screenshot

Screenshot 2023-09-18 at 4 30 30 PM

(Side note: I was unable to upload a screen recording because it exceeded GitHub's 10 MB file upload limit. Is that limit new?)

NickLaiacona commented 1 year ago

This looks good! A couple of small things, one is that I can still see the yellow outline when I creep up on a box with the mouse pointer:

Screen Shot 2023-09-19 at 8 49 49 AM

The other thing, more for @cblissg is that I when the boxes aren't selected, they are this grey, which can be difficult to see:

Screen Shot 2023-09-19 at 8 49 54 AM

camdendotlol commented 1 year ago

Hm, there should be hover styling. I'll check it out on Chrome and see if there might be a browser-compatiblity issue with the CSS rules.

NickLaiacona commented 1 year ago

What's odd is that it is blue when it the mouse is fully over the box but yellow when it is near the box.

camdendotlol commented 1 year ago

Aha, Annotorious was doing something fancy where instead of using the :hover selector, it applies a hover class that triggers when the mouse begins to approach the box, even if it's not actually hovering over it.

I replaced my use of :hover with .hover and now it looks good on my end.