Closed ajolipa closed 9 months ago
Hi @ajolipa , two things on this PR. First, can you move the code into a branch in this repo instead of a fork in your own repo? Second, the PR merge target should be either the develop branch or a develop branch just for ely-green related features. Thanks!
In this PR
Adds the option to configure the
EditionCrafter
component to accept multiple documents, by setting thevariorum
prop to true and passing in an object with document IDs as keys as thedocumentInfo
object.For example, a variorum configuration could look like
This results in the following behavior, including the ability to unlock the two panes from each other and view a folio from one document on one side and another document on the other side:
Notes and future work
variorum
to true, etc., the viewer will crash.variorum
is set to true, then an empty glossary is returned. Presumably each document could come with its own glossary link, so instead of loading the glossary when initializing the grid view, I suppose it should be loaded from the proper manifest once a specific folio is chosen? But implementing that will take another chunk of work.