Closed ajolipa closed 8 months ago
This is a great start, very exciting! Some UI feedback:
Implemented the bullet points suggested above; @NickLaiacona go ahead and re-review whenever you have a chance!
@ajolipa looks great! only one comment here - when you are not in variorum mode and looking at the grid view, you just see the grid icon but nothing beside it. Could we display the name of the document there, not as a drop down but just a label?
@NickLaiacona Implemented the document name display for the non-variorum grid mode. Look it over when you get a chance!
@ajolipa this looks good - one last nit on this PR - could you remove the "View All" option from the drop down? I think it will just confuse folks.
@NickLaiacona Just did a push that should address these most recent concerns; let me know how it looks.
In this PR
Adds the option to configure the
EditionCrafter
component to accept multiple documents, by setting thevariorum
prop to true and passing in an object with document IDs as keys as thedocumentInfo
object.For example, a variorum configuration could look like
This results in the following behavior, including the ability to unlock the two panes from each other and view a folio from one document on one side and another document on the other side:
Notes and future work
variorum
to true, etc., the viewer will crash.variorum
is set to true, then an empty glossary is returned. Presumably each document could come with its own glossary link, so instead of loading the glossary when initializing the grid view, I suppose it should be loaded from the proper manifest once a specific folio is chosen? But implementing that will take another chunk of work.