Closed ajolipa closed 6 months ago
Hi @ajolipa, please go ahead and modify https://cu-mkp.github.io/editioncrafter-data/fr640_3r-3v-example/glossary.json to be structured like this:
{
title: <string>,
citation: <string>,
entries: { .. }
}
please use the value of the title field for subtitle
Applied the changes suggested above and updated the GalleryView
component accordingly.
In this PR
glossaryURL
, e.g.div
with no specified height; in this case rather than height 100% the viewer will default to filling the size of the screen.TranscriptionView
component is now set to14px
.Notes and further work
Previously the subtitle and citation information as seen below were hardcoded into the
GlossaryView
component. For now I set it up so that those items will look forglossary.glossary_metadata.subtitle
andglossary.glossary_metadata.citation
fields in the JSON of the glossary and if it doesn't find them it will return the original hardcoded content. However that's not really a good structure since currently the glossary JSON object is just a list of words; there shouldn't actually be aglossary_metadata
field that's a sibling of all the words in the glossary. So more thought is needed about where that meta information should be coming from.