cu-mkp / m-k-manuscript-data

Text of BnF Ms Fr 640 in multiple formats, metadata about the manuscript, and derived data
13 stars 5 forks source link

122r: figures inside <del> not rendering #1598

Closed njr2128 closed 4 years ago

njr2128 commented 4 years ago

While present in xml of all three versions (tc, tcn, tl), two figures are not rendering, likely because they are inside del tags.

I think @thuchacz and I decided to put them in del tags to more accurately reflect the author's intention of "deleting" them.

However, it seems Nick is not expecting figs inside del. We either remove the del tags or see how involved it would be for Nick to accept fig inside del.

image

ps2270 commented 4 years ago

it would be great to show the figure that was deleted, but if it can't be done, shall we just put an editorial comment on the image - is that possible?

On Tue, Apr 7, 2020 at 10:52 AM Naomi Rosenkranz notifications@github.com wrote:

While present in xml of all three versions (tc, tcn, tl), two figures are not rendering, likely because they are inside del tags.

I think @thuchacz https://github.com/thuchacz and I decided to put them in del tags to more accurately reflect the author's intention of "deleting" them.

However, it seems Nick is not expecting figs inside del. We either remove the del tags or see how involved it would be for Nick to accept fig inside del.

[image: image] https://user-images.githubusercontent.com/14779727/78683893-d7080300-78bd-11ea-82c1-09a5deb33181.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cu-mkp/m-k-manuscript-data/issues/1598, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF75UYE7PL3WJ7RXDC6VJJ3RLM44BANCNFSM4MDFV3HQ .

-- Pamela H. Smith Seth Low Professor of History http://history.columbia.edu/faculty/smith-pamela-h/ The Making and Knowing Project

Director, Center for Science and Society http://scienceandsociety.columbia.edu/ Chair, Presidential Scholars in Society and Neuroscience https://presidentialscholars.columbia.edu/ Columbia University 605 Fayerweather Hall, MC 2516 1180 Amsterdam Avenue New York, N.Y. 10027 (212) 854-7662-Phone (212) 851-5963-Fax ps2270@columbia.edu

The Making and Knowing Project has just released Secrets of Craft and Nature in Renaissance France: A Digital Critical Edition and English Translation of BnF Ms. Fr. 640: http://edition640.makingandknowing.org

Entangled Itineraries: Materials, Practices, and Knowledges across Eurasia https://www.upress.pitt.edu/books/9780822965770/ is now available. The Body of the Artisan http://press.uchicago.edu/ucp/books/book/chicago/B/bo3618964.html has been reissued in paperback and electronic editions. The Business of Alchemy https://press.princeton.edu/titles/10868.html is available in a new paperback.

njr2128 commented 4 years ago

Counterpoint: on 22r the cannonball is "crossed out" and hence "deleted," yet we have not enclosed in del tags. https://edition640.makingandknowing.org/#/folios/22r/f/22r/tl This makes an argument to NOT put in del tags

ps2270 commented 4 years ago

I think I agree with that counterpoint, Naomi. Let's not put them in delete tags.

On Mon, Apr 13, 2020 at 3:56 PM Naomi Rosenkranz notifications@github.com wrote:

Counterpoint: on 22r the cannonball is "crossed out" and hence "deleted," yet we have not enclosed in del tags. https://edition640.makingandknowing.org/#/folios/22r/f/22r/tl This makes an argument to NOT put in del tags

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cu-mkp/m-k-manuscript-data/issues/1598#issuecomment-613068023, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF75UYFIJWSBHMGLFUJKCYDRMNU7XANCNFSM4MDFV3HQ .

-- Pamela H. Smith Seth Low Professor of History http://history.columbia.edu/faculty/smith-pamela-h/ The Making and Knowing Project

Director, Center for Science and Society http://scienceandsociety.columbia.edu/ Chair, Presidential Scholars in Society and Neuroscience https://presidentialscholars.columbia.edu/ Columbia University 605 Fayerweather Hall, MC 2516 1180 Amsterdam Avenue New York, N.Y. 10027 (212) 854-7662-Phone (212) 851-5963-Fax ps2270@columbia.edu

The Making and Knowing Project has just released Secrets of Craft and Nature in Renaissance France: A Digital Critical Edition and English Translation of BnF Ms. Fr. 640: http://edition640.makingandknowing.org

Entangled Itineraries: Materials, Practices, and Knowledges across Eurasia https://www.upress.pitt.edu/books/9780822965770/ is now available. The Body of the Artisan http://press.uchicago.edu/ucp/books/book/chicago/B/bo3618964.html has been reissued in paperback and electronic editions. The Business of Alchemy https://press.princeton.edu/titles/10868.html is available in a new paperback.

thuchacz commented 4 years ago

Decision: remove the <del> tags. Moved images to the previous div, where they belonged. Done.