cu-numpde / fall23-community-Christina-wg

fall23-community-Christina-wg created by GitHub Classroom
0 stars 0 forks source link

Feedback #1

Open github-classroom[bot] opened 1 year ago

github-classroom[bot] commented 1 year ago

:wave:! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher. In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens. Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.

Subscribed: @Christina-wg

jedbrown commented 12 months ago

Looks like a good plan. I would consider a problem like 2D shallow water or 2D Euler. You could run a test with a smooth solution (I like example 2.2 of https://doi.org/10.4208/cicp.291109.080410s) and then add a strong shock (you'll no longer have an exact solution, but you can still do a grid refinement study).