cu-uis / cu-starterkit-project

Development repository for Pantheon's recommended (future) Drupal 9+ upstream
1 stars 2 forks source link

Feature - As a Developer, I want the CU Base theme available as a composer dependency in the starter template #53

Open meschenbaum opened 2 years ago

meschenbaum commented 2 years ago

Is your feature request related to a problem? Please describe.

With the CU Base theme in its own repo, we would like it as part of the composer dependencies for the upstream starter template.

Describe the solution you'd like

Adding the theme repo to the upstream composer will allow us to set version ranges for the starter template while allowing projects to pin to a version/branch.

References:

kreynen commented 2 years ago

I opened https://github.com/cu-uis/cu-starterkit-project/issues/58 and re-opened this issue. Changes made to the root level composer.json have to be resolved at the project level if it doesn't merge cleanly. This did not.

kreynen commented 2 years ago

Reverted with https://github.com/cu-uis/cu-starterkit-project/pull/63

kreynen commented 2 years ago

"Platform" level error from Pantheon support...

Screen Shot 2022-05-24 at 10 41 24 PM

The issue is composer can't replace an existing directory with composer so it fails (without an accessible error), but GitHub doesn't because it is a clean install. This is an order of operation error.