search

cuappdev / eatery-ios

An open-source iOS app for Cornell eateries and dining halls.
MIT License
29 stars 11 forks source link

Bottom of dinner menus getting cutoff #239

Open ReadeP opened 4 years ago

ReadeP commented 4 years ago

To replicate the issue: 1) Select North Star dining hall during breakfast 3) Select dinner menu and scroll down to the bottom of the menu

If you select lunch then select dinner, the dinner menu will be fully displayed.

This bug can only be replicated during breakfast time, as the breakfast menu needs to appear first.

Simulator Screen Shot - iPhone 11 - 2019-10-22 at 10 28 15

whoiswillma commented 4 years ago

We are setting a height constraint on the page view controller based on the content size of the tableview. My hypothesis is that the tableview doesn't know its actual height until all the cells are reloaded.

The proper way to fix this would be to rewrite the meal view controller to use a stack view.