Fix bugs that occur when two duplicate songs appear on feed from diff…

[ChenJesse]

…erent users

257

[loganallen]

If it works, looks good to me

[ChenJesse]

Ok I thought of a slightly better way to organize the checks, I'll get it done by tonight...I just thought we were submitting yesterday so I rushed to bug fix

[say25]

SONG ID?

[ChenJesse]

What do you mean?

[say25]

Songs have a unique Spotify given ID on them. If a user posts truly the same song it by definition has the same song id. that is probably the best way to determine duplicates

[ChenJesse]

Oh, the problem isn't prevent different users from posting the same song, it's dealing with how the logic determines which song is playing when two of them are identical. I do what you're talking about when I do song1.equals(other: song2), which compares IDs. But that alone is not sufficient for when two people you follow post the same song (with same songIDs, since the one further up in the tableview will always get played first)

Dennis was talking about ways to compare User objects, and I didn't see a field that is guaranteed to be unique. Username is guaranteed to be unique, the backend does a check for that whenever you're changing it, which is why I chose it. The only concern is if you change your username, but even if you change the username, the User object is still in memory so it should be fine.

[dennisfedorko]

I guess using username is about the same as id, so works for me

[ChenJesse]

Ok, fixed up the style, using id for comparing Users, and now defines Post equality as having the same equal users and songs.

Also I found a few other bugs and fixed them:

• Scrolling away from a spinning feedCell and coming back would sometimes stop animation
• Pull to refresh animation continuity of playing song was inconsistent, moved the function call to a better place

[dennisfedorko]

Merge it