Cross device compatibility changes.

cuappdev / tempo

An open-source iOS app for music discovery and sharing with friends.

MIT License

15 stars 1 forks source link

Cross device compatibility changes. #266

Closed keivanshahida closed 7 years ago

keivanshahida commented 7 years ago

iPhone 5 compatibility changes - adaptive text sizing, etc.
Tested across all devices (iPhone 5, 6, 7)

ChenJesse commented 7 years ago

Functionally it's fine, and this is a nitpicky detail but it feels like the <= 320 logic is duplicated (getting screenSize, etc.). I think it would be better to have a variable in UIView+Utilities.swift that simply does that screen size logic checking, that you can then call from the two views