cub-uanic / tmk_keyboard

keyboard controller firmware for Atmel AVR USB family
158 stars 157 forks source link

LEDS turn off when left hand reconnected #27

Open marknsikora opened 9 years ago

marknsikora commented 9 years ago

Fairly simple to reproduce using the default layout.

  1. Turn on num lock so LED1 is on
  2. Unplug and reattach left hand
  3. Switch to num pad layer
  4. The num pad works even though the LED1 is off

The light can be re-enabled by toggling the num lock twice

marknsikora commented 8 years ago

The source of the bug seems to be coming from this line as far as I can tell. Fix should be as simple as saving the current leds before blinking and restoring after. Will test later when I have some time.

kaimi commented 8 years ago

You shouldn’t really mess with the TRRS as long as the keyboard is powered. It’s not built for hot plugging and you can potentially short circuit stuff.