Open squarefrog opened 8 years ago
I agree with most of what's here. But I guess one thing to discuss is the issue of how to handle the move to tmk_core. The main issue I see with keeping the current repo is the name. As you pointed out earlier one of the repos using the new scheme is called BenBergman/bluetooth_kinesis. And I imagine we would want to end up with something like tmk_ergodox for ourselves (to help differentiate us from the other ergodox firmware).
The way I see it there are some pros and cons to keeping the current repo as is.
Pro
Con
tmk_core
it would require manual intervention from anyone who has forked this repo to add their own layout. For example, they would need to move their specific header files to the root, and include them in the Makefile
.Keeping the git history is possible providing someone pushes a local copy of this repo to a new repository, but that would distance itself as a fork, which is no bad thing. I personally think the right thing to do when moving to core is separation, but I do feel that the move should be the last thing we tackle as there are a few outstanding Pull Requests based on the current structure.
I ran across this repo which may serve as a useful base if we choose to go the submodule route https://github.com/fredizzimo/infinity_ergodox
I've actually done it :
https://github.com/squarefrog/tmk_ergodox
It's really simple and elegant.
/keyboard/ergodox
To the root dirMakefile
The only thing I am missing is https://github.com/cub-uanic/tmk_keyboard/pull/23
I'd do a pull request on tmk_core
but it's very unlikely that it'll get merged.
I kind of wish QMK went the same route so it'd be easy to try it in a branch. I don't really want to go back to the old project structure.
@squarefrog it looks like dev is moving over to the ErgoDox group, can you add me to that group so I can continue my work there
@marknsikora I can't as I'm not an owner of that repo. Ask @wobbol
Yea sure @marknsikora, it's no problem. Actually, Ive already sent you an invitation.
I think it would be a good idea to establish some sort of road map to limit duplication of work here. It would be good to get this fork to a state where it's easy for other contributors to help out.
Here's what I foresee as the priority of updates for the near future:
QWERTY, Dvorak, Colemak, Workman)Makefile.lufa
default, rename toMakefile
, and recommend that that should be the one to use unlessMakefile.pjrc
is something that is really neededtmk_core
as a submodule, and move the Ergodox specific files to the root of the projectdocs/
directory with the current FAQ file, or move to Wiki.README
with basic git and build instructions to make it much easier for newcomers to dive right inI'm open to suggestions for anything else we've missed here. I'm happy to split up the work with @marknsikora to sprint to get this list done.