search

cub-uanic / tmk_keyboard

keyboard controller firmware for Atmel AVR USB family
158 stars 157 forks source link

Dvorak Layout #35

Closed Xyverz closed 8 years ago

Xyverz commented 8 years ago

Here's the pull request with my Dvorak layout. I've made it a bit more generic. I wasn't sure if you wanted this submitted to the keymap_dvorak.h file, so I committed it as keymap_xyverz.h.

marknsikora commented 8 years ago

The existing dvorak layout is empty, feel free to put your layout there. Yours doesn't seem to contain too much personal stuff so will be a good base layout for dvorak users.

Xyverz commented 8 years ago

Okay, I'll add this to the dvorak file and make another pull request.

Should I just close this pull request and delete the file from my fork?

squarefrog commented 8 years ago

No - while you have this Pull Request open, and changes you push will be reflected here. Thanks for submitting this @Xyverz !

Xyverz commented 8 years ago

Ignore my last comment. I see that the updated keymap_dvorak.h file is there.

squarefrog commented 8 years ago

Sorry for not getting back to you @Xyverz - thanks for submitting this, I've merged it in now.

marknsikora commented 8 years ago

This merge won't work. It's still using the old layout scheme.

squarefrog commented 8 years ago

Fixed in cbf4e5b6ff774d53013a3c2d10852858600a8d7e 👍

Xyverz commented 8 years ago

Thanks for fixing that. Much appreciated. On Jun 7, 2016 11:50, "Paul Williamson" notifications@github.com wrote:

Fixed in cbf4e5b https://github.com/cub-uanic/tmk_keyboard/commit/cbf4e5b6ff774d53013a3c2d10852858600a8d7e 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cub-uanic/tmk_keyboard/pull/35#issuecomment-224377765, or mute the thread https://github.com/notifications/unsubscribe/ARvqOgwTHqiWrTNfUuv9HW2kyS0eeVWZks5qJb1fgaJpZM4IpM4v .