cub-uanic / tmk_keyboard

keyboard controller firmware for Atmel AVR USB family
158 stars 157 forks source link

Add colemak layout #36

Closed squarefrog closed 8 years ago

squarefrog commented 8 years ago

Added a 3 layer colemak based layout.

Layer 0: Standard colemak layout Layer 1: Function, media and arrow keys Layer 2: Num pad

I've built and tested it, so its ready for review and merge. If I don't hear any objections after a week I'll merge it 👍

marknsikora commented 8 years ago

Looks good. My only worry would be the placement of the VOLU VOLD and MUTE buttons which don't match the function layer of blazak. .

squarefrog commented 8 years ago

Yeah so we have two options here. This is the blazek colemak layout we are referencing.

  1. We essentially port the blazek layouts here. This would mean that anyone using a stock layout from the blazek firmware would be up and running pretty easy here.
  2. We roll our own, which is what I've done here. This gives us a little scope for improvement.

I think this layout is fairly opinionated - it's based off my experience of using my ErgoDox for 18 months. Personally, what I didn't like about the blazek one was its reliance on the thumb clusters for modifier keys. I don't know about you but I find the 1U keys in the thumb clusters not all that useful. I found it much easier to transition having CTRL, ALT and GUI in the same places as a standard keyboard.

Either way, I'm really not that precious about this layout so if you have any suggestions I'm all ears 👂

marknsikora commented 8 years ago

I think this is good to merge, I can't think of any reason not to right now