cube-drone / pierc

A python bot that logs IRC channels, and a PHP/JS interface for browsing said logs.
http://classam.github.com/pierc/
Other
52 stars 24 forks source link

Spanifying words breaks things #18

Closed ThomasGirard closed 11 years ago

ThomasGirard commented 11 years ago

When the log displays a sentence such as "Did you get my message ?" the word message gets turned to a <span class="message"> and gets the .message style from the theme CSS applied. The problem is repeatable with other words that match a CSS class.

The word "date" gets the .date class and thus disappears from the log.

message-bug

cube-drone commented 11 years ago

That is a truefact. Discussions about the topic are highlighted in blue, when someone asks about the date it looks teeny-tiny... I had just ignored it because it didn't really break anything, but as the style of the site evolves it's going to cause wierdness.

Laziest solution would be to replace the style names with things that people are unlikely to ever say in conversation, like style_date and style_message.

ThomasGirard commented 11 years ago

I see that you modify the class names (e.g. I tried highlight-1 but the span had class highlight1) so a good solution would be to use only classes with dashes in the CSS, as those will never be generated.

frdmn commented 11 years ago

This should do it and is probably the better way.

ThomasGirard commented 11 years ago

Works ok. Thanks :)