search

cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.97k stars 1.78k forks source link

`shouldFetchDryRun` should consider changes made to filters #3552

Open john-nexkey opened 3 years ago

john-nexkey commented 3 years ago

Describe the bug When I modify filters using updateFilters methods within QueryBuilder, a dry run does not occur as expected. Adding filters to the existing shouldFetchDryRun array (['measures', 'dimensions', 'timeDimensions']) fixes the issue.

To Reproduce Steps to reproduce the behavior:

  1. Call updateFilters.add QueryBuilder (@cubejs-client/react) to modify filters
  2. A dry run does not occur

Expected behavior I expect a filter change to prompt a dry run.

Screenshots https://github.com/cube-js/cube.js/blob/master/packages/cubejs-client-react/src/QueryBuilder.jsx#L485-L488

Version: 0.28.43

Additional context Add any other context about the problem here.

github-actions[bot] commented 3 years ago

If you are interested in working on this issue, please leave a comment below and we will be happy to assign the issue to you. If this is the first time you are contributing a Pull Request to Cube.js, please check our contribution guidelines. You can also post any questions while contributing in the #contributors channel in the Cube.js Slack.