cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.99k stars 1.78k forks source link

chore(cubesql): Do not call async Node functions while planning #8793

Open MazterQyou opened 1 month ago

MazterQyou commented 1 month ago

Check List

Description of Changes Made

This PR restructures the way compiler cache works, removing the need to call async Node functions while planning, at the cost of passing around compiler_id.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/J7mrNPsYSazRV85PHQpndLxNkNMH)) | [Visit Preview](https://examples-angular-dashboard-git-cubesql-no-async-58ab4c-cube-dev.vercel.app) | | Nov 20, 2024 5:16pm | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/3LsFwYY4jvr6dnqEV9t2k3hxHdmk)) | [Visit Preview](https://examples-react-d3-git-cubesql-no-async-node-wit-e1c59f-cube-dev.vercel.app) | | Nov 20, 2024 5:16pm | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/HycKgx3J17x7U1qT71ggqc9Ar5b3)) | [Visit Preview](https://examples-react-dashboard-git-cubesql-no-async-n-37d995-cube-dev.vercel.app) | | Nov 20, 2024 5:16pm | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/D99K6UfWL6ph1eVVLDzwEdvFPLaq)) | [Visit Preview](https://examples-react-data-table-git-cubesql-no-async-a80077-cube-dev.vercel.app) | | Nov 20, 2024 5:16pm | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/5EvUcTKrWqKvP27FMUYYVGppxH19)) | [Visit Preview](https://examples-react-highcharts-git-cubesql-no-async-384d9a-cube-dev.vercel.app) | | Nov 20, 2024 5:16pm | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/2hbE6SErESqawKxGsgwVeZfaXmHF)) | [Visit Preview](https://examples-react-material-ui-git-cubesql-no-async-bf2b08-cube-dev.vercel.app) | | Nov 20, 2024 5:16pm | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/74uk7kehDfCgrGxHjM7soRPN3SYb)) | [Visit Preview](https://examples-react-pivot-table-git-cubesql-no-async-5d13b4-cube-dev.vercel.app) | | Nov 20, 2024 5:16pm | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/4EAUjWUVUMWyzka67o5rxKPSSKsK)) | [Visit Preview](https://examples-vue-query-builder-git-cubesql-no-async-7c0f2c-cube-dev.vercel.app) | | Nov 20, 2024 5:16pm |
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.42424% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.68%. Comparing base (591a383) to head (23315a0).

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/query_engine.rs 86.79% 7 Missing :warning:
rust/cubesql/cubesql/src/sql/compiler_cache.rs 94.54% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8793 +/- ## ========================================== - Coverage 82.69% 82.68% -0.01% ========================================== Files 221 221 Lines 78467 78474 +7 ========================================== Hits 64888 64888 - Misses 13579 13586 +7 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8793/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8793/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.68% <92.42%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: