cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.96k stars 1.78k forks source link

refactor(cubesql): QueryRouter - remove recursion on explain planing #8820

Closed ovr closed 1 month ago

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/FTZbCo9X1c3Q9DVWf63YWZykSWJU)) | [Visit Preview](https://examples-angular-dashboard-git-refactor-query-r-3f981b-cube-dev.vercel.app) | | Oct 16, 2024 0:08am | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/fFZYhrWHvnu9GC7ZkmZYnV9EJtzd)) | [Visit Preview](https://examples-react-d3-git-refactor-query-router-no-bd4082-cube-dev.vercel.app) | | Oct 16, 2024 0:08am | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/FKFyyPj99T1ZitppvEXEjPQFf2vS)) | [Visit Preview](https://examples-react-dashboard-git-refactor-query-rou-807972-cube-dev.vercel.app) | | Oct 16, 2024 0:08am | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/758gcJrsc4eiVaMnCDTNNuS3a49Z)) | [Visit Preview](https://examples-react-data-table-git-refactor-query-ro-1fe94d-cube-dev.vercel.app) | | Oct 16, 2024 0:08am | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/9jBJHsRKzHZzuvuQnKGoDe7r9xHK)) | [Visit Preview](https://examples-react-highcharts-git-refactor-query-ro-4f336a-cube-dev.vercel.app) | | Oct 16, 2024 0:08am | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/2vSFRW6XS77TzhYXmmhH267jUaaD)) | [Visit Preview](https://examples-react-material-ui-git-refactor-query-r-4eb8d9-cube-dev.vercel.app) | | Oct 16, 2024 0:08am | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/4mNzqt35SH89dwsaoHNhfCW2pAsF)) | [Visit Preview](https://examples-react-pivot-table-git-refactor-query-r-d8412d-cube-dev.vercel.app) | | Oct 16, 2024 0:08am | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/5kkAFfCjHZL72Eu6dpnxfNKfq6zJ)) | [Visit Preview](https://examples-vue-query-builder-git-refactor-query-r-899db9-cube-dev.vercel.app) | | Oct 16, 2024 0:08am |
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 70.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (5935964) to head (8f68d51). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/router.rs 70.00% 18 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8820 +/- ## ========================================== - Coverage 82.75% 82.74% -0.02% ========================================== Files 219 219 Lines 78235 78236 +1 ========================================== - Hits 64745 64737 -8 - Misses 13490 13499 +9 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8820/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.74% <70.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.