cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.98k stars 1.78k forks source link

refactor(cubesql): Extract cube join condition check for rewrites to separate function #8835

Open mcheshkov opened 1 month ago

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/F4Sv65TZnQvMnzrUdavdz4oLQLsV)) | [Visit Preview](https://examples-angular-dashboard-git-extract-cube-joi-a03d9c-cube-dev.vercel.app) | | Nov 13, 2024 11:55am | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/AAhDPC3FHTGaVLArU13CHn9L9JU2)) | [Visit Preview](https://examples-react-d3-git-extract-cube-join-field-check-cube-dev.vercel.app) | | Nov 13, 2024 11:55am | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/HHKKRUcygKVGMftX4vtKnMFc1Fvd)) | [Visit Preview](https://examples-react-dashboard-git-extract-cube-join-97fd96-cube-dev.vercel.app) | | Nov 13, 2024 11:55am | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/GAp9ASDmbbgBHati17tuJb4MM3LE)) | [Visit Preview](https://examples-react-data-table-git-extract-cube-join-cece6a-cube-dev.vercel.app) | | Nov 13, 2024 11:55am | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/5mV5tY5AiN37vZP83YGmm3AXicKH)) | [Visit Preview](https://examples-react-highcharts-git-extract-cube-join-36611c-cube-dev.vercel.app) | | Nov 13, 2024 11:55am | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/8qkTij8UDsBVcPi5FzVbEsBqWnnj)) | [Visit Preview](https://examples-react-material-ui-git-extract-cube-joi-69efa0-cube-dev.vercel.app) | | Nov 13, 2024 11:55am | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/7jnxHfhw7y1iEZ98WMkhfDJQ8tnv)) | [Visit Preview](https://examples-react-pivot-table-git-extract-cube-joi-cedcde-cube-dev.vercel.app) | | Nov 13, 2024 11:55am | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/8ZmgqASxDKC1kunjQMgeyJb2M7Ln)) | [Visit Preview](https://examples-vue-query-builder-git-extract-cube-joi-3efa99-cube-dev.vercel.app) | | Nov 13, 2024 11:55am |
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (5fd13d1) to head (4659f8c).

Files with missing lines Patch % Lines
...besql/cubesql/src/compile/rewrite/rules/members.rs 98.70% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8835 +/- ## ======================================= Coverage 82.66% 82.66% ======================================= Files 221 221 Lines 78303 78318 +15 ======================================= + Hits 64726 64742 +16 + Misses 13577 13576 -1 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8835/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8835/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.66% <98.70%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.