cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.98k stars 1.78k forks source link

refactor(cubesql): Add CubeEGraph and CubeRewrite type aliases #8848

Closed mcheshkov closed 1 month ago

mcheshkov commented 1 month ago

Check List

Description of Changes Made (if issue reference is not provided)

Just to reduce clutter a bit

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 81.84713% with 57 lines in your changes missing coverage. Please review.

Project coverage is 82.52%. Comparing base (34dc819) to head (f590292). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...sql/cubesql/src/compile/rewrite/rules/old_split.rs 0.00% 40 Missing :warning:
...cubesql/cubesql/src/compile/rewrite/rules/utils.rs 0.00% 5 Missing :warning:
rust/cubesql/cubesql/src/compile/qtrace.rs 0.00% 2 Missing :warning:
rust/cubesql/cubesql/src/compile/rewrite/mod.rs 91.66% 2 Missing :warning:
.../cubesql/cubesql/src/compile/rewrite/rules/case.rs 0.00% 2 Missing :warning:
...besql/cubesql/src/compile/rewrite/rules/members.rs 93.54% 2 Missing :warning:
...st/cubesql/cubesql/src/compile/rewrite/rewriter.rs 87.50% 1 Missing :warning:
...sql/src/compile/rewrite/rules/flatten/top_level.rs 80.00% 1 Missing :warning:
...t/cubesql/cubesql/src/compile/rewrite/rules/mod.rs 83.33% 1 Missing :warning:
...cubesql/cubesql/src/compile/test/rewrite_engine.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8848 +/- ## ========================================== - Coverage 82.55% 82.52% -0.03% ========================================== Files 221 221 Lines 77830 77572 -258 ========================================== - Hits 64249 64017 -232 + Misses 13581 13555 -26 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8848/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8848/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.52% <81.84%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/Bq7D8GCvhQQZFxQrUvuuxeyoYH15)) | [Visit Preview](https://examples-angular-dashboard-git-egraph-rewrite-t-dfaa15-cube-dev.vercel.app) | | Oct 22, 2024 2:34pm | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/5tq8DbDhE7qTJkNrHLeGSAeXPzvE)) | [Visit Preview](https://examples-react-d3-git-egraph-rewrite-type-aliases-cube-dev.vercel.app) | | Oct 22, 2024 2:34pm | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/DsdYxb8ziKr4K3HucdFfuWPGJt6h)) | [Visit Preview](https://examples-react-dashboard-git-egraph-rewrite-typ-d8f8ce-cube-dev.vercel.app) | | Oct 22, 2024 2:34pm | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/9vf1M6CQ2nVCYf9AfPNoci25oYMk)) | [Visit Preview](https://examples-react-data-table-git-egraph-rewrite-ty-d675d0-cube-dev.vercel.app) | | Oct 22, 2024 2:34pm | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/7JpqgtWu3yB9DF8cEYTUjjTzZF6o)) | [Visit Preview](https://examples-react-highcharts-git-egraph-rewrite-ty-c244cb-cube-dev.vercel.app) | | Oct 22, 2024 2:34pm | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/NNeEvJxDCGxwQ5ULvD5L92mdzUPm)) | [Visit Preview](https://examples-react-material-ui-git-egraph-rewrite-t-409b1a-cube-dev.vercel.app) | | Oct 22, 2024 2:34pm | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/3ekE7iEScfP2FCgLUifyJPG4XjME)) | [Visit Preview](https://examples-react-pivot-table-git-egraph-rewrite-t-3b6de9-cube-dev.vercel.app) | | Oct 22, 2024 2:34pm | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/CpD6aNQqiVUc1DDncxK1bdFK1vnQ)) | [Visit Preview](https://examples-vue-query-builder-git-egraph-rewrite-t-a41be9-cube-dev.vercel.app) | | Oct 22, 2024 2:34pm |