cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.96k stars 1.78k forks source link

refactor(cubesql): Add explicit check for ungroupedness #8861

Closed mcheshkov closed 3 weeks ago

mcheshkov commented 4 weeks ago

Check List

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/4xadJg9YDX3QZLJbrvnn1v5kN1az)) | [Visit Preview](https://examples-angular-dashboard-git-wrapped-select-e-03645c-cube-dev.vercel.app) | | Oct 29, 2024 3:19pm | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/2UDoAL1CsS49TJpjR1BAxCpTmECU)) | [Visit Preview](https://examples-react-d3-git-wrapped-select-explicit-u-bfadb7-cube-dev.vercel.app) | | Oct 29, 2024 3:19pm | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/9XfhTqTgUKwqNp1N6g1KX2A7eo5o)) | [Visit Preview](https://examples-react-dashboard-git-wrapped-select-exp-d8bcbf-cube-dev.vercel.app) | | Oct 29, 2024 3:19pm | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/8LSi3dQnaDScmnYQRkmDTKRwR8s4)) | [Visit Preview](https://examples-react-data-table-git-wrapped-select-ex-1e0a71-cube-dev.vercel.app) | | Oct 29, 2024 3:19pm | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/3AbeVV2gUszfeMbZnJ1ftFrh1QC6)) | [Visit Preview](https://examples-react-highcharts-git-wrapped-select-ex-83e7df-cube-dev.vercel.app) | | Oct 29, 2024 3:19pm | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/6uhwvSzWSmd2KXdAioHJGgFJqD6E)) | [Visit Preview](https://examples-react-material-ui-git-wrapped-select-e-3a5ccb-cube-dev.vercel.app) | | Oct 29, 2024 3:19pm | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/6Qo6uU7AR1ynZ9U1bUAGEbUjDdWH)) | [Visit Preview](https://examples-react-pivot-table-git-wrapped-select-e-2ed0e6-cube-dev.vercel.app) | | Oct 29, 2024 3:19pm | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/DyKG5AbZA7QuSugBcowHoyScoqYY)) | [Visit Preview](https://examples-vue-query-builder-git-wrapped-select-e-d26c9d-cube-dev.vercel.app) | | Oct 29, 2024 3:19pm |
codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.50%. Comparing base (fa4b3b8) to head (566567c). Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 40.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8861 +/- ## ======================================= Coverage 82.50% 82.50% ======================================= Files 221 221 Lines 77597 77602 +5 ======================================= + Hits 64022 64027 +5 Misses 13575 13575 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8861/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.50% <40.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.