cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.98k stars 1.78k forks source link

refactor(cubesql): Rename ungrouped field of WrappedSelectNode to push_to_cube #8862

Closed mcheshkov closed 1 week ago

mcheshkov commented 1 month ago

Check List

Description of Changes Made (if issue reference is not provided)

This name seems more appropriate, because actual WrappedSelect can represent grouped query when this field is set to true

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/J1TreGkEP7bXK5KukAivbnkKbqae)) | | | Oct 24, 2024 0:18am | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/DifJ1Ba1AnsWYVakjiVYxmPs348T)) | | | Oct 24, 2024 0:18am | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/EimVNY3YN26tYmvcsAHWED73TH7Q)) | | | Oct 24, 2024 0:18am | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/2UyFMtZ6S2Hsjrzj7yewgecJBUvN)) | | | Oct 24, 2024 0:18am | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/BwYZfgUkG7bnK9r55HcRNkNaVkNa)) | | | Oct 24, 2024 0:18am | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/97azNFYZ1C5pkrd31b6ooDqjrwQ2)) | | | Oct 24, 2024 0:18am | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/6rBWCXH5nM5vRxcYw3fn88sYcZcm)) | | | Oct 24, 2024 0:18am | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/BcRwQgP1WxKXRoofEZC3Rby2ja9g)) | | | Oct 24, 2024 0:18am |
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 98.57143% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.51%. Comparing base (15f5a12) to head (9d4e1ad). Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8862 +/- ## ========================================== - Coverage 82.52% 82.51% -0.02% ========================================== Files 221 221 Lines 77572 77602 +30 ========================================== + Hits 64017 64030 +13 - Misses 13555 13572 +17 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8862/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8862/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.51% <98.57%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mcheshkov commented 1 week ago

Merged in #8888