cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.96k stars 1.78k forks source link

fix(schema-compiler): return granularity-truncated queries in client time zone #8877

Closed KSDaemon closed 3 weeks ago

KSDaemon commented 3 weeks ago

Time dimensions with granularities were returned always in UTC. This fixes it and now dimensions are returned in client time zones.

Check List

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/GeR5xHqc3E5aEyWW41cRWLw2jmah)) | [Visit Preview](https://examples-angular-dashboard-git-fix-granularitie-edad38-cube-dev.vercel.app) | | Oct 29, 2024 0:06am | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/8fLmPipKpVoMyr86MZajPYuGPpau)) | [Visit Preview](https://examples-react-d3-git-fix-granularities-timezones-cube-dev.vercel.app) | | Oct 29, 2024 0:06am | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/B36N2hVnWk7LLQ8FhBg9gtbnf79K)) | [Visit Preview](https://examples-react-dashboard-git-fix-granularities-c19177-cube-dev.vercel.app) | | Oct 29, 2024 0:06am | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/CjRST96RrNisd5QRxUafWwBDk4Mm)) | [Visit Preview](https://examples-react-data-table-git-fix-granularities-0849f0-cube-dev.vercel.app) | | Oct 29, 2024 0:06am | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/DnHmcjeZK6ovj849ej4FgtwDAko8)) | [Visit Preview](https://examples-react-highcharts-git-fix-granularities-71b002-cube-dev.vercel.app) | | Oct 29, 2024 0:06am | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/xEuRg4izeshXVmRPyF2MjJhppWZa)) | [Visit Preview](https://examples-react-material-ui-git-fix-granularitie-419cf3-cube-dev.vercel.app) | | Oct 29, 2024 0:06am | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/3LvY8JVAmPxqRXLHZmebXvzgTBAc)) | [Visit Preview](https://examples-react-pivot-table-git-fix-granularitie-063368-cube-dev.vercel.app) | | Oct 29, 2024 0:06am | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/57Jek9VGGnYSGt7iW2sZ5siq9k2C)) | [Visit Preview](https://examples-vue-query-builder-git-fix-granularitie-3b6789-cube-dev.vercel.app) | | Oct 29, 2024 0:06am |
igorlukanin commented 3 weeks ago

Nice bug! Does the fix deserve to be backported to 1.0.x? 😄

KSDaemon commented 3 weeks ago

@igorlukanin I think so! Here it is: https://github.com/cube-js/cube/pull/8878