cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.96k stars 1.78k forks source link

fix(cubesql): Add forgotten Distinct in ast_size_outside_wrapper cost component #8882

Open mcheshkov opened 3 weeks ago

mcheshkov commented 3 weeks ago

Check List

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/FHygRvNkZQbrL4zy9Tv9FTAo7BFR)) | [Visit Preview](https://examples-angular-dashboard-git-forgotten-distinct-cost-cube-dev.vercel.app) | | Nov 13, 2024 11:58am | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/CS5GZmBYdHqbZSdNf41EvXBxAmXk)) | [Visit Preview](https://examples-react-d3-git-forgotten-distinct-cost-cube-dev.vercel.app) | | Nov 13, 2024 11:58am | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/35hSHATnR5ws3qk8kbbcyvHjRB1m)) | [Visit Preview](https://examples-react-dashboard-git-forgotten-distinct-cost-cube-dev.vercel.app) | | Nov 13, 2024 11:58am | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/D3cxW6WwazBuAcSNrEVNM6L98Ft3)) | [Visit Preview](https://examples-react-data-table-git-forgotten-distinct-cost-cube-dev.vercel.app) | | Nov 13, 2024 11:58am | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/29SexHmdngpvT2fN8xWV1xoMmtbx)) | [Visit Preview](https://examples-react-highcharts-git-forgotten-distinct-cost-cube-dev.vercel.app) | | Nov 13, 2024 11:58am | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/3YWwKstwzCwmgKxmHtDm9qEJ2r4J)) | [Visit Preview](https://examples-react-material-ui-git-forgotten-distinct-cost-cube-dev.vercel.app) | | Nov 13, 2024 11:58am | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/9GuLYYXiRhf1mtgMyc48p92aPWKZ)) | [Visit Preview](https://examples-react-pivot-table-git-forgotten-distinct-cost-cube-dev.vercel.app) | | Nov 13, 2024 11:58am | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/HVqHKWz7rsYHuFMvx7phUjcpxJ1R)) | [Visit Preview](https://examples-vue-query-builder-git-forgotten-distinct-cost-cube-dev.vercel.app) | | Nov 13, 2024 11:58am |
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.66%. Comparing base (5fd13d1) to head (2710fe3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8882 +/- ## ======================================= Coverage 82.66% 82.66% ======================================= Files 221 221 Lines 78303 78304 +1 ======================================= + Hits 64726 64729 +3 + Misses 13577 13575 -2 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8882/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8882/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.66% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.