codecov[bot]
commented
3 weeks ago Codecov Report
Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
Project coverage is 82.55%. Comparing base (
e02f612) to head (240947f). Report is 1 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...besql/cubesql/src/compile/rewrite/rules/members.rs | 88.00% | 3 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #8883 +/- ## ======================================= Coverage 82.55% 82.55% ======================================= Files 221 221 Lines 77709 77734 +25 ======================================= + Hits 64151 64174 +23 - Misses 13558 13560 +2 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8883/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8883/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.55% <88.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
vercel[bot]
Check List
Description of Changes Made (if issue reference is not provided)
Without these checks TableScan->CubeScan rule is, technically, unsound. For now it's just a sanity check.