cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.96k stars 1.78k forks source link

feat(cubesql): Initial SQL pushdown flattening #8888

Closed mcheshkov closed 1 week ago

mcheshkov commented 3 weeks ago

Check List

Description of Changes Made (if issue reference is not provided)

Flatten Aggregation(Filter(CubeScan)) to a single CubeScanWrapper(push_to_cube=true)

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/AcUv3hSWsoZLEBnAk6mumJdyCNV6)) | [Visit Preview](https://examples-angular-dashboard-git-wrapper-initial-2b7386-cube-dev.vercel.app) | | Nov 12, 2024 0:34am | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/4QAJ5gwZ3pfbv397Fe8ZLgqtSiyJ)) | [Visit Preview](https://examples-react-d3-git-wrapper-initial-flattening-cube-dev.vercel.app) | | Nov 12, 2024 0:34am | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/mCn339Ay8XtTdsUPo2AJyi7KuXpv)) | [Visit Preview](https://examples-react-dashboard-git-wrapper-initial-fl-7a55bb-cube-dev.vercel.app) | | Nov 12, 2024 0:34am | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/5yB5ne9AV9BR6EBq7GFYMLmzHjmb)) | [Visit Preview](https://examples-react-data-table-git-wrapper-initial-f-f68da5-cube-dev.vercel.app) | | Nov 12, 2024 0:34am | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/66ZdDF779kptsXKqhDJVmeGYhQ1r)) | [Visit Preview](https://examples-react-highcharts-git-wrapper-initial-f-8b81b9-cube-dev.vercel.app) | | Nov 12, 2024 0:34am | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/4yNSyAPQgJJzvVZ5hwQcBa4jdw7c)) | [Visit Preview](https://examples-react-material-ui-git-wrapper-initial-ab7de3-cube-dev.vercel.app) | | Nov 12, 2024 0:34am | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/2fnXPRTsyVV49q4P1GknD5RKaSF5)) | [Visit Preview](https://examples-react-pivot-table-git-wrapper-initial-f1f127-cube-dev.vercel.app) | | Nov 12, 2024 0:34am | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/AUNHbM7tbgij4DN5ak9TQvvNdA8w)) | [Visit Preview](https://examples-vue-query-builder-git-wrapper-initial-6ae7dd-cube-dev.vercel.app) | | Nov 12, 2024 0:34am |
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 97.90076% with 22 lines in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (a7bab04) to head (77e4461). Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...c/compile/rewrite/rules/wrapper/scalar_function.rs 81.57% 7 Missing :warning:
...l/cubesql/src/compile/rewrite/rules/wrapper/mod.rs 95.77% 3 Missing :warning:
...besql/src/compile/rewrite/rules/wrapper/literal.rs 94.87% 2 Missing :warning:
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 66.66% 1 Missing :warning:
...sql/src/compile/rewrite/rules/wrapper/aggregate.rs 99.55% 1 Missing :warning:
...ubesql/src/compile/rewrite/rules/wrapper/filter.rs 98.52% 1 Missing :warning:
.../src/compile/rewrite/rules/wrapper/in_list_expr.rs 96.00% 1 Missing :warning:
.../compile/rewrite/rules/wrapper/in_subquery_expr.rs 96.15% 1 Missing :warning:
...cubesql/src/compile/rewrite/rules/wrapper/order.rs 96.77% 1 Missing :warning:
...ql/src/compile/rewrite/rules/wrapper/projection.rs 98.41% 1 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8888 +/- ## ========================================== + Coverage 82.55% 82.66% +0.11% ========================================== Files 221 221 Lines 77734 78324 +590 ========================================== + Hits 64174 64750 +576 - Misses 13560 13574 +14 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8888/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.66% <97.90%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.