cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.96k stars 1.78k forks source link

fix(cubesql): Fix `NULLS FIRST`/`LAST` SQL push down for several dialects #8895

Closed MazterQyou closed 2 weeks ago

MazterQyou commented 2 weeks ago

Check List

Description of Changes Made

This PR fixes NULLS FIRST/NULLS LAST for dialects that don't support the clause, emulating it with IS NULL. Related test is included.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.55%. Comparing base (15afec1) to head (868fde1). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8895 +/- ## ======================================= Coverage 82.54% 82.55% ======================================= Files 221 221 Lines 77667 77703 +36 ======================================= + Hits 64111 64147 +36 Misses 13556 13556 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8895/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.55% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/HghQKBGbUoBePvFNfejLaApuwonU)) | [Visit Preview](https://examples-angular-dashboard-git-cubesql-nulls-fi-5a8705-cube-dev.vercel.app) | | Nov 7, 2024 9:45pm | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/6kHRW1U5nCUY26bvpp5pwjkwqqSV)) | [Visit Preview](https://examples-react-d3-git-cubesql-nulls-first-last-fix-cube-dev.vercel.app) | | Nov 7, 2024 9:45pm | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/4J2tj8XJr1e74jTNd4pnZ4NicG7p)) | [Visit Preview](https://examples-react-dashboard-git-cubesql-nulls-firs-357141-cube-dev.vercel.app) | | Nov 7, 2024 9:45pm | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/Cs6YhSPWy3GrFCpNJbRyBfdoy7mv)) | [Visit Preview](https://examples-react-data-table-git-cubesql-nulls-fir-bfd9c6-cube-dev.vercel.app) | | Nov 7, 2024 9:45pm | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/HYsHSKPLHMvYrpqQtDKZCWR5Z9xW)) | [Visit Preview](https://examples-react-highcharts-git-cubesql-nulls-fir-f6c18d-cube-dev.vercel.app) | | Nov 7, 2024 9:45pm | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/6FCrd5kGCWWVs63UVjBuGgNhwTHM)) | [Visit Preview](https://examples-react-material-ui-git-cubesql-nulls-fi-de8aad-cube-dev.vercel.app) | | Nov 7, 2024 9:45pm | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/AMVR76CHBFKL9yqKhwLtNEBuufzi)) | [Visit Preview](https://examples-react-pivot-table-git-cubesql-nulls-fi-32d82e-cube-dev.vercel.app) | | Nov 7, 2024 9:45pm | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/F1wTFmpUyVAtEK8tDkmWfjiN6UF9)) | [Visit Preview](https://examples-vue-query-builder-git-cubesql-nulls-fi-bf6f57-cube-dev.vercel.app) | | Nov 7, 2024 9:45pm |