codecov[bot]
commented
2 weeks ago Codecov Report
Attention: Patch coverage is 99.66044% with 2 lines in your changes missing coverage. Please review.
Project coverage is 82.66%. Comparing base (
8e815c2) to head (80ea85b).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...besql/cubesql/src/compile/rewrite/rules/members.rs | 96.15% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #8924 +/- ## ========================================== + Coverage 82.55% 82.66% +0.11% ========================================== Files 221 222 +1 Lines 77703 78244 +541 ========================================== + Hits 64146 64681 +535 - Misses 13557 13563 +6 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8924/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.66% <99.66%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
vercel[bot]
Check List
Description of Changes Made (if issue reference is not provided)
Before this in
Limit(Limit(CubeScan))logical plan outer fetch and skip values would win. Not they are calculated properly.