Open mcheshkov opened 2 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Attention: Patch coverage is 97.82609%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 82.70%. Comparing base (
5fd13d1
) to head (6376543
).
Files with missing lines | Patch % | Lines |
---|---|---|
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs | 96.68% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Check List
Description of Changes Made (if issue reference is not provided)
This would allow to extract fully assembled
CubeScan
under wrapper instead ofCubeScan(allMembers, ungrouped=true)
.ATM there are two related components in cost:
non_detected_cube_scans
andcube_members
non_detected_cube_scans
allows to penalizeCubeScan
without members specifically outside the wrapper. This is pretty hard penalty, queries like that are Not Good™cube_members
allows to prefer queries will less members, which seems fine. But on it's own it would prefer query with zero member, which is, actually, all the members. So, new cost component added:zero_members_wrapper
. It would stand right beforecube_members
, and allow to penalize no-members representation beforecube_members
starts impacting extraction.New
CubeScan
extractions surfaced a couple of bugs related to aliasing in generated SQL, hence all the supporting stuff in this PR.