cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.96k stars 1.78k forks source link

fix(cubesql): Allow aggregation pushdown only for unlimited CubeScan #8929

Open mcheshkov opened 2 weeks ago

mcheshkov commented 2 weeks ago

Check List

Description of Changes Made (if issue reference is not provided)

Aggregate(CubeScan(limit=n)) is not equivalent to CubeScan(aggregation, limit=n) Former does aggregation over first n rows, latter returns first n rows after aggregation.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/ACtuhL6e3ska6jEZJUXxSQgMUQ8r)) | [Visit Preview](https://examples-angular-dashboard-git-deny-aggregation-30fd23-cube-dev.vercel.app) | | Nov 13, 2024 11:38am | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/A8ZkhRovAoc1wVkQUiAHRFY9bMmT)) | [Visit Preview](https://examples-react-d3-git-deny-aggregation-over-limit-cube-dev.vercel.app) | | Nov 13, 2024 11:38am | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/EYHAjgkdeqqNNTVpezwSVbWQQQaW)) | [Visit Preview](https://examples-react-dashboard-git-deny-aggregation-o-4d5784-cube-dev.vercel.app) | | Nov 13, 2024 11:38am | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/6w4wUtzK2YXu5cN9V2D1hwRmpqJx)) | [Visit Preview](https://examples-react-data-table-git-deny-aggregation-92cc93-cube-dev.vercel.app) | | Nov 13, 2024 11:38am | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/HseCUqvLaqtT9SPofboFH4EqJ5tC)) | [Visit Preview](https://examples-react-highcharts-git-deny-aggregation-127aa7-cube-dev.vercel.app) | | Nov 13, 2024 11:38am | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/4fHQ4rNLutfNj2S3zYJxFwzaKiG3)) | [Visit Preview](https://examples-react-material-ui-git-deny-aggregation-b6bbe9-cube-dev.vercel.app) | | Nov 13, 2024 11:38am | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/4MmFFaJC5tDSLTCrumNCJu6VJamH)) | [Visit Preview](https://examples-react-pivot-table-git-deny-aggregation-c4ae79-cube-dev.vercel.app) | | Nov 13, 2024 11:38am | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/HG16mmGuys4vzBCwjYMx5pyVe15f)) | [Visit Preview](https://examples-vue-query-builder-git-deny-aggregation-4ae8fb-cube-dev.vercel.app) | | Nov 13, 2024 11:38am |
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.69%. Comparing base (5fd13d1) to head (f9925b7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8929 +/- ## ========================================== + Coverage 82.66% 82.69% +0.03% ========================================== Files 221 221 Lines 78303 78438 +135 ========================================== + Hits 64726 64865 +139 + Misses 13577 13573 -4 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8929/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8929/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.69% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.