cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.96k stars 1.78k forks source link

refactor(cubesql): Improve EGraph debugger, part 3: parsing and data preparation in UI side #8934

Open mcheshkov opened 1 week ago

mcheshkov commented 1 week ago

Check List

Description of Changes Made (if issue reference is not provided)

Add proper parsing on UI side, to catch data format changes. Move most of data preparation related to UI (like a concepts of edge or combo) to UI completely, simplify data collection on rewriter side.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (5fd13d1) to head (05e20cb). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...st/cubesql/cubesql/src/compile/rewrite/rewriter.rs 0.00% 47 Missing :warning:
...st/cubesql/cubesql/src/compile/rewrite/analysis.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8934 +/- ## ========================================== + Coverage 82.66% 82.72% +0.06% ========================================== Files 221 221 Lines 78303 78244 -59 ========================================== + Hits 64726 64727 +1 + Misses 13577 13517 -60 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8934/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8934/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.72% <0.00%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/AAgW7nMxJBDn42jkF8P2LqkXp3VH)) | [Visit Preview](https://examples-angular-dashboard-git-refactor-egraph-349ee2-cube-dev.vercel.app) | | Nov 15, 2024 11:46am | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/7DWoyJdj51MDCa6kFbW7upYuL7fB)) | [Visit Preview](https://examples-react-d3-git-refactor-egraph-debugger-3-cube-dev.vercel.app) | | Nov 15, 2024 11:46am | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/Dj4TrMwHCzhZKUbeYjQbPx2iTL8j)) | [Visit Preview](https://examples-react-dashboard-git-refactor-egraph-de-ba37a0-cube-dev.vercel.app) | | Nov 15, 2024 11:46am | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/84aMujR4CdtbxTbLNzFCDAGeSrKv)) | [Visit Preview](https://examples-react-data-table-git-refactor-egraph-d-add1b3-cube-dev.vercel.app) | | Nov 15, 2024 11:46am | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/4C3Y8cf6aSH4dy6XiruREE3vLJBY)) | [Visit Preview](https://examples-react-highcharts-git-refactor-egraph-d-8a30a9-cube-dev.vercel.app) | | Nov 15, 2024 11:46am | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/FWZKkkyBdCGGYv191RiDf5JeX6aE)) | [Visit Preview](https://examples-react-material-ui-git-refactor-egraph-2b0198-cube-dev.vercel.app) | | Nov 15, 2024 11:46am | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/972KVuVT7g38TsGrmuccxud6BfQs)) | [Visit Preview](https://examples-react-pivot-table-git-refactor-egraph-d8e2ee-cube-dev.vercel.app) | | Nov 15, 2024 11:46am | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/3eQCB28eiupua11AsjfRXW3MZsPb)) | [Visit Preview](https://examples-vue-query-builder-git-refactor-egraph-4333d4-cube-dev.vercel.app) | | Nov 15, 2024 11:46am |