vercel[bot]
commented
1 week ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
Open pauldheinrichs opened 1 week ago
vercel[bot]
commented
1 week ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
pauldheinrichs
commented
1 week ago 2024-11-13 13:29:54,605 ERROR [Cube SQL Error] {"error": "Error during processing PostgreSQL message: CubeError: error in reqwest: builder error", "appName": "NULL", "protocol": "postgres", "apiType": "sql"}
thread 'main' panicked at cubesql/e2e/tests/postgres.rs:316:25:
unexpected return, simple query must be cancelled, actual: Ok(())doesn't appear related to my changes, all specs i've added have passed 🤔
droidraja
commented
6 days ago 2024-11-13 13:29:54,605 ERROR [Cube SQL Error] {"error": "Error during processing PostgreSQL message: CubeError: error in reqwest: builder error", "appName": "NULL", "protocol": "postgres", "apiType": "sql"} thread 'main' panicked at cubesql/e2e/tests/postgres.rs:316:25: unexpected return, simple query must be cancelled, actual: Ok(())doesn't appear related to my changes, all specs i've added have passed 🤔
@pauldheinrichs My PR is also failing with the same set of tests. I was trying to find a PR for which this GHA was succeeding. https://github.com/cube-js/cube/pull/8902 Will be watching this thread for any updates.
ovr
commented
3 days ago I am not sure, but I prepared a potential fix for the CI issue: https://github.com/cube-js/cube/commit/b75a37a8ea3f258817480c1ea00b3e93b2434512
@pauldheinrichs Could you please rebase your PR? Thanks!
pauldheinrichs
commented
3 days ago I am not sure, but I prepared a potential fix for the CI issue: b75a37a
@pauldheinrichs Could you please rebase your PR? Thanks!
@ovr All set! Rebased!
codecov[bot]
commented
3 days ago Attention: Patch coverage is 86.95652% with 33 lines in your changes missing coverage. Please review.
Project coverage is 79.76%. Comparing base (
b75a37a) to head (99db541). Report is 3 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...t/cubesql/cubesql/src/compile/engine/udf/common.rs | 73.80% | 33 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
pauldheinrichs
commented
1 day ago @ovr Is there anything further you'd like to see in this PR? I'd love to merge this so we can update our metabase instance
Semi-resolves: https://github.com/cube-js/cube/issues/8926
Hoping to unblock metabase failing field sync on it's latest version. This pull requests implements
formatmacroIt also noops
schema.tableidentifiers)I don't have a tonne of bandwidth to fully implement the missing macro but this at least helps unblock the current request metabase is making to cube and failing when attempting to sync-fields.
It's not entirely clear if there's already an inherent way to lookup the table OID to get that result from the RegClass result to be leveraged in col_description implementation
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]