[ ] Tests has been run in packages where changes made if available
[ ] Linter has been run for changed code
[ ] Tests for the changes have been added if not covered yet
[ ] Docs have been added / updated if required
Issue Reference this PR resolves
Fixes #8949
Description of Changes Made
Add aarch64-apple-darwin as a build target to the cubestore matrix and update getTarget() to return aarch64-apple-darwin to darwin on arm64 instead of returning x86_64-apple-darwin and requiring Rosetta 2.
A previous attempt appears to have been made by @ovr on #2658 but seems to have been abandoned (perhaps because at the time GitHub actions did not have a ARM64 macOS runner? It was made available on Jan 2024).
I ran the workflow rust-cubestore-master.yml, downloaded the artifact resulting from the new job cubestore (aarch64-apple-darwin) to a macbook w/ arm64 and confirmed that #8949 is solved.
I am not familiar with the build/release infrastructure of Cube. Please review and let me know if any changes should be made. Thanks!
Check List
Issue Reference this PR resolves
Fixes #8949
Description of Changes Made
Add
aarch64-apple-darwin
as a build target to thecubestore
matrix and updategetTarget()
to returnaarch64-apple-darwin
to darwin on arm64 instead of returningx86_64-apple-darwin
and requiring Rosetta 2.A previous attempt appears to have been made by @ovr on #2658 but seems to have been abandoned (perhaps because at the time GitHub actions did not have a ARM64 macOS runner? It was made available on Jan 2024).
I ran the workflow
rust-cubestore-master.yml
, downloaded the artifact resulting from the new jobcubestore (aarch64-apple-darwin)
to a macbook w/ arm64 and confirmed that #8949 is solved.I am not familiar with the build/release infrastructure of Cube. Please review and let me know if any changes should be made. Thanks!