cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.96k stars 1.78k forks source link

Add aarch64-apple-darwin build target to cubestore #8950

Closed vieira closed 1 week ago

vieira commented 1 week ago

Check List

Issue Reference this PR resolves

Fixes #8949

Description of Changes Made

Add aarch64-apple-darwin as a build target to the cubestore matrix and update getTarget() to return aarch64-apple-darwin to darwin on arm64 instead of returning x86_64-apple-darwin and requiring Rosetta 2.

A previous attempt appears to have been made by @ovr on #2658 but seems to have been abandoned (perhaps because at the time GitHub actions did not have a ARM64 macOS runner? It was made available on Jan 2024).

I ran the workflow rust-cubestore-master.yml, downloaded the artifact resulting from the new job cubestore (aarch64-apple-darwin) to a macbook w/ arm64 and confirmed that #8949 is solved.

I am not familiar with the build/release infrastructure of Cube. Please review and let me know if any changes should be made. Thanks!

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/G67cvUGgY7mgVBCkAmdmEUG9aG3E)) | [Visit Preview](https://examples-angular-dashboard-git-fork-vieira-master-cube-dev.vercel.app) | | Nov 13, 2024 10:51am | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/71rk4Swdobdhi68c1viHkBLK2wL3)) | [Visit Preview](https://examples-react-d3-git-fork-vieira-master-cube-dev.vercel.app) | | Nov 13, 2024 10:51am | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/H9zKoDkCKGN4HjCzAZwKptSkg9j9)) | [Visit Preview](https://examples-react-dashboard-git-fork-vieira-master-cube-dev.vercel.app) | | Nov 13, 2024 10:51am | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/3k3Q7Kn6VWV87VbSV7g74yXU27dN)) | [Visit Preview](https://examples-react-data-table-git-fork-vieira-master-cube-dev.vercel.app) | | Nov 13, 2024 10:51am | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/5L81f6PETRGQquq7vYm9U1Dmj6P1)) | [Visit Preview](https://examples-react-highcharts-git-fork-vieira-master-cube-dev.vercel.app) | | Nov 13, 2024 10:51am | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/47aRC7Pr88fN2euwQziRCdc3Eqsz)) | [Visit Preview](https://examples-react-material-ui-git-fork-vieira-master-cube-dev.vercel.app) | | Nov 13, 2024 10:51am | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/8JHUMETjhvS9HzumKh8ZBaFyjUZG)) | [Visit Preview](https://examples-react-pivot-table-git-fork-vieira-master-cube-dev.vercel.app) | | Nov 13, 2024 10:51am | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/A1JDcRQmKhciX8wNcYNhusVZDkzv)) | [Visit Preview](https://examples-vue-query-builder-git-fork-vieira-master-cube-dev.vercel.app) | | Nov 13, 2024 10:51am |
ovr commented 1 week ago

the time GitHub actions did not have a ARM64 macOS runner

Yes, it's correct.

ovr commented 1 week ago

LGTM, merged!

Thank you @vieira for your contribution 🍰 🍥