cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.96k stars 1.78k forks source link

fix(cubesql): fix unhandled timestamp unwrapping in df/transform_response #8952

Closed KSDaemon closed 1 day ago

KSDaemon commented 1 week ago

This PR fixes timestamp parsing handling unwrapping that may lead to panic:

thread 'tokio-runtime-worker' panicked at cube/rust/cubesql/cubesql/src/compile/engine/df/scan.rs:1133:86:
called `Option::unwrap()` on a `None` value

Check List

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/298HdarqLyCjriRrHA3ykpqLnT5b)) | [Visit Preview](https://examples-angular-dashboard-git-fix-unwrap-in-tr-813e6a-cube-dev.vercel.app) | | Nov 13, 2024 0:39am | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/HwfyXdDVnuiYpoSvPWmgjoE4Snip)) | [Visit Preview](https://examples-react-d3-git-fix-unwrap-in-transform-response-cube-dev.vercel.app) | | Nov 13, 2024 0:39am | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/Fd71F3d6wNcMhdyDLdo2a7f3hbPH)) | [Visit Preview](https://examples-react-dashboard-git-fix-unwrap-in-tran-101fcd-cube-dev.vercel.app) | | Nov 13, 2024 0:39am | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/HRzmiUTty5ngzDyRmw8HiEKWe97g)) | [Visit Preview](https://examples-react-data-table-git-fix-unwrap-in-tra-84e7f5-cube-dev.vercel.app) | | Nov 13, 2024 0:39am | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/5jmkBCkfPnwcc54sJM8S2aXL8zSY)) | [Visit Preview](https://examples-react-highcharts-git-fix-unwrap-in-tra-53e14a-cube-dev.vercel.app) | | Nov 13, 2024 0:39am | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/W9bNDE8rPa3tuUDwmBZbAhVvvPLo)) | [Visit Preview](https://examples-react-material-ui-git-fix-unwrap-in-tr-fc8811-cube-dev.vercel.app) | | Nov 13, 2024 0:39am | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/8cQeHGWYnHsYxPNWMvFME9Zbh7NW)) | [Visit Preview](https://examples-react-pivot-table-git-fix-unwrap-in-tr-a851d4-cube-dev.vercel.app) | | Nov 13, 2024 0:39am | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/3te9gSvpsVTGbAMFnzzoyAeVeDzR)) | [Visit Preview](https://examples-vue-query-builder-git-fix-unwrap-in-tr-9bd003-cube-dev.vercel.app) | | Nov 13, 2024 0:39am |
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.65%. Comparing base (211d1c1) to head (5deb2a3). Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 42.85% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8952 +/- ## ======================================= Coverage 82.65% 82.65% ======================================= Files 221 221 Lines 78303 78308 +5 ======================================= + Hits 64722 64728 +6 + Misses 13581 13580 -1 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8952/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8952/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.65% <42.85%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: