Open pauldheinrichs opened 5 days ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Hi @pauldheinrichs 👋 Thanks a ton for this contribution!
I'll let my team mates review this PR. And I feel like this, while not being formally a breaking change (since it was documented and there's a bug filed), is still a somewhat radical deviation from the behavior that has been part of Cube for at least a couple of years already. I believe merging this can lead to data model breakages, so it look like we should consider this for a minor, no a patch, release. Cc @paveltiunov
https://github.com/cube-js/cube/issues/7137 - the docs specify this is supported. So adding the support for it 🤷
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]