cube-js / cube

📊 Cube — Universal semantic layer platform for AI, BI, spreadsheets, and embedded analytics
https://cube.dev
Other
17.97k stars 1.78k forks source link

fix(schema-compiler) support join inheritance #8970

Open pauldheinrichs opened 5 days ago

pauldheinrichs commented 5 days ago

https://github.com/cube-js/cube/issues/7137 - the docs specify this is supported. So adding the support for it 🤷

image

Check List

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **examples-angular-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-angular-dashboard/Bvh7d5uQ4hzcwL9mBEvKMAW5jeA2)) | [Visit Preview](https://examples-angular-dashboard-git-fork-pauldheinri-1d283d-cube-dev.vercel.app) | | Nov 19, 2024 5:19pm | | **examples-react-d3** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-d3/5dsj6euztFQaRjN1Ey69wnChntjb)) | [Visit Preview](https://examples-react-d3-git-fork-pauldheinrichs-ph-su-e746c4-cube-dev.vercel.app) | | Nov 19, 2024 5:19pm | | **examples-react-dashboard** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-dashboard/9Kz9xhhhdtoEkdRCSDQ2vMb64rMy)) | [Visit Preview](https://examples-react-dashboard-git-fork-pauldheinrich-06b35e-cube-dev.vercel.app) | | Nov 19, 2024 5:19pm | | **examples-react-data-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-data-table/CowqCFaLcVV8t3KHjZ1hfyd6FVt1)) | [Visit Preview](https://examples-react-data-table-git-fork-pauldheinric-d462cd-cube-dev.vercel.app) | | Nov 19, 2024 5:19pm | | **examples-react-highcharts** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-highcharts/EWXLG3zxgpwoVZgbQ5PXvTXAbu3Q)) | [Visit Preview](https://examples-react-highcharts-git-fork-pauldheinric-f8cbdb-cube-dev.vercel.app) | | Nov 19, 2024 5:19pm | | **examples-react-material-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-material-ui/873ZZsKyLSUQs9RcxAr5Ze6FiU72)) | [Visit Preview](https://examples-react-material-ui-git-fork-pauldheinri-4dad9f-cube-dev.vercel.app) | | Nov 19, 2024 5:19pm | | **examples-react-pivot-table** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-react-pivot-table/A4t3DbgZHThVHYebkDUADAM7cq6H)) | [Visit Preview](https://examples-react-pivot-table-git-fork-pauldheinri-5d3e67-cube-dev.vercel.app) | | Nov 19, 2024 5:19pm | | **examples-vue-query-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/cube-dev/examples-vue-query-builder/7ycsvkXXooTPMASAvbSMc1cZDSxZ)) | [Visit Preview](https://examples-vue-query-builder-git-fork-pauldheinri-b2818e-cube-dev.vercel.app) | | Nov 19, 2024 5:19pm |
igorlukanin commented 2 days ago

Hi @pauldheinrichs 👋 Thanks a ton for this contribution!

I'll let my team mates review this PR. And I feel like this, while not being formally a breaking change (since it was documented and there's a bug filed), is still a somewhat radical deviation from the behavior that has been part of Cube for at least a couple of years already. I believe merging this can lead to data model breakages, so it look like we should consider this for a minor, no a patch, release. Cc @paveltiunov