codecov[bot]
commented
2 days ago Codecov Report
Attention: Patch coverage is 96.42857% with 6 lines in your changes missing coverage. Please review.
Project coverage is 82.69%. Comparing base (
b75a37a) to head (0fb5a56). Report is 6 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs | 25.00% | 6 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #8971 +/- ## ========================================== + Coverage 82.66% 82.69% +0.02% ========================================== Files 221 221 Lines 78303 78467 +164 ========================================== + Hits 64727 64885 +158 - Misses 13576 13582 +6 ``` | [Flag](https://app.codecov.io/gh/cube-js/cube/pull/8971/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | Coverage Δ | | |---|---|---| | [cubesql](https://app.codecov.io/gh/cube-js/cube/pull/8971/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js) | `82.69% <96.42%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cube-js#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
- Flaky Tests Detection - Detect and resolve failed and flaky tests
- JS Bundle Analysis - Avoid shipping oversized bundles
vercel[bot]
Check List
Issue Reference this PR resolves
8967
Description of Changes Made (if issue reference is not provided)
cubesql can introduce
ScalarValue::TimestampNanosecond(..., Some("UTC"))during constant folding, andgenerate_sql_for_exprtrips on unsupported timezones. This PR just allowsNoneas well asSome("UTC")as timezones. Because DataFusion will always generateUTC, it should be fine for now. See https://github.com/cube-js/arrow-datafusion/blob/dcf3e4aa26fd112043ef26fa4a78db5dbd443c86/datafusion/physical-expr/src/datetime_expressions.rs#L357-L367